Open Metaverse JIRA issue tracker

  • Log In Access more options
    • Online Help
    • GreenHopper Help
    • Agile Answers
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What’s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Agile
  • libopenmetaverse
  • LIBOMV-859

SimPosition reporting RelativePosition when avatar is sitting

  • Voters
  • Watchers
  • More Actions
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 0.8.2
  • Fix Version/s: 0.8.3
  • Component/s: Avatars
  • Labels:
    None
  • Severity:
    High
  • Environment:
    All
  • Steps to Reproduce:
    Hide

    Sit on an object and observe SimPosition and anything related to it...

    Show
    Sit on an object and observe SimPosition and anything related to it...

Description

When an avatar is sitting SimPosition is reporting Relative position which throws many functions off route. Attached is a patch that resolves this issue.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    LIBOMV-859.patch
    25/Jul/10 6:54 AM
    0.8 kB
    Latif Khalifa
  2. Text File
    SimPositionFix.patch
    25/Jul/10 5:53 AM
    2 kB
    Legolas Luke

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • History
  • Activity
  • Commits
Hide
Permalink
Robin Cornelius added a comment - 25/Jul/10 6:33 AM

Its suspose to return a relative position because the avatar is then a child object of the prim it is sitting on. This is how the protocol on the wire works and everyone with libomv clients already does a check to see if the agent is sitting then does a offset and rotation from the parent prim. Fixing this would break any clients that want to actually see where the agent is sitting WRT the prim it is sitting on.

Show
Robin Cornelius added a comment - 25/Jul/10 6:33 AM Its suspose to return a relative position because the avatar is then a child object of the prim it is sitting on. This is how the protocol on the wire works and everyone with libomv clients already does a check to see if the agent is sitting then does a offset and rotation from the parent prim. Fixing this would break any clients that want to actually see where the agent is sitting WRT the prim it is sitting on.
Hide
Permalink
Latif Khalifa added a comment - 25/Jul/10 6:38 AM

We have code that traverses ParentID hirearchy to find a root prim, I can reproduce the problem, trying to figure out why ParentID doesn't seem to be populated correctly.

Show
Latif Khalifa added a comment - 25/Jul/10 6:38 AM We have code that traverses ParentID hirearchy to find a root prim, I can reproduce the problem, trying to figure out why ParentID doesn't seem to be populated correctly.
Hide
Permalink
Legolas Luke added a comment - 25/Jul/10 6:41 AM



With all respect I have to agree to disagree with you Robin. Simposition should report the absolute position of the avatar. RelavitvePosition should report the relative postion relating to SIM as the function name suggests.Otherwise what is the point if they both behave the same???

Show
Legolas Luke added a comment - 25/Jul/10 6:41 AM With all respect I have to agree to disagree with you Robin. Simposition should report the absolute position of the avatar. RelavitvePosition should report the relative postion relating to SIM as the function name suggests.Otherwise what is the point if they both behave the same???
Hide
Permalink
Legolas Luke added a comment - 25/Jul/10 6:48 AM


It is failing cos the code you have is looking for the parent of the parent of the parent....etc. There can be only one parent and not multiple..no? Even if not before this certainly seems to be the case in SIM V 1.40. Sit down on an object on a V 1.40 SIM and you will see what I am referrign to...

Show
Legolas Luke added a comment - 25/Jul/10 6:48 AM It is failing cos the code you have is looking for the parent of the parent of the parent....etc. There can be only one parent and not multiple..no? Even if not before this certainly seems to be the case in SIM V 1.40. Sit down on an object on a V 1.40 SIM and you will see what I am referrign to...
Hide
Permalink
Latif Khalifa added a comment - 25/Jul/10 6:54 AM - edited

Legolas, could you please try LIBOMV-859.patch and see if it fixes problem for you. We're trying to keep compatibility with OpenSim which does this slightly differently.

Show
Latif Khalifa added a comment - 25/Jul/10 6:54 AM - edited Legolas, could you please try LIBOMV-859.patch and see if it fixes problem for you. We're trying to keep compatibility with OpenSim which does this slightly differently.
Hide
Permalink
Robin Cornelius added a comment - 25/Jul/10 6:55 AM

@Legolas, good point, i retract my statment

Show
Robin Cornelius added a comment - 25/Jul/10 6:55 AM @Legolas, good point, i retract my statment
Hide
Permalink
Latif Khalifa added a comment - 25/Jul/10 7:00 AM

In OpenSim, when avatar sits on a child prim, it's parent ID is that of the child prim, so one has to go one more step back to find the root prim. There is some talk about allowing avatars to sit on attachments too.

I've tried to make a universal method, but have unfortunately missed the first step, if there is no hierarchy sigh.

Show
Latif Khalifa added a comment - 25/Jul/10 7:00 AM In OpenSim, when avatar sits on a child prim, it's parent ID is that of the child prim, so one has to go one more step back to find the root prim. There is some talk about allowing avatars to sit on attachments too. I've tried to make a universal method, but have unfortunately missed the first step, if there is no hierarchy sigh.
Hide
Permalink
Legolas Luke added a comment - 25/Jul/10 7:32 AM



Thx Latif that patch sorted the issue out and I am more than pleased we have a solution that pleases SL as well as OpenSIM. Great work guys. Ty very much

Show
Legolas Luke added a comment - 25/Jul/10 7:32 AM Thx Latif that patch sorted the issue out and I am more than pleased we have a solution that pleases SL as well as OpenSIM. Great work guys. Ty very much

People

  • Assignee:
    Latif Khalifa
    Reporter:
    Legolas Luke
Vote (0)
Watch (1)

Dates

  • Created:
    25/Jul/10 5:53 AM
    Updated:
    15/Jan/12 7:11 PM
    Resolved:
    25/Jul/10 7:34 AM

Agile

  • View on Board
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Radegast Metaverse Client. Try JIRA - bug tracking software for your team.